-
Notifications
You must be signed in to change notification settings - Fork 15
LEP-006: external module repository #12
base: master
Are you sure you want to change the base?
Conversation
Hey @CurlyMoo, thanks for writing this! We somehow already agreed upon doing that, quite some time ago, however not much has happened since: https://github.com/libuv/libuv-extras I think what we need to kickstart it is a story for the build system, and some initial code. You seem to already have the code ready, which is great, maybe send an initial PR with one of the modules to trigger the discussion? |
Do we want to start the discussion with an initial PR, or do we want to have some guideliness set before we do that PR? It now seems that everything is possible 😄 |
At this point I'd say let's go with a PR, that would give reviewers some code to work with. As I said the idea for an extras repo has existed for a while, but nobody has put the effort in adding code there so far, so I don't see how more discussion around guidelines is going to make an impact ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammar nits, but otherwise SGTM.
|
||
Proposal | ||
======== | ||
For my own software `pilight` i have developed various modules that i use on top of libuv. The reason for me to develop this stuff myself and not use existing libraries, is that i can use a single libuv loop for all functionality i need. Using external libraries require additional threads, additional non-blocking io loops etc. The downside of this, is that my code is not as complete as some existing libraries, and the code is probably of less quality. Despite all of this, what i've written so far is: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/i/I/g
|
||
However, that of course doesn't mean that things cannot be improved further with the help of others. | ||
|
||
So, my proposal is to create a repository that hosts all kinds external components built on top of libuv. Other developers can then help maintain the code and ensure its functionality and quality. By having these modules stored close to libuv, other developers can more easily find extisting implementations on top of libuv, and make use of it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/extisting/existing/
I've pushed the first code to libuv/libuv-extras#2 |
No description provided.